Add external_edit_file_suffix to config
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
reviewed
Apr 10, 2024
| @@ -557,6 +559,9 @@ impl Tunables { | |||
| notifications: self.notifications.or(other.notifications), | |||
| image_preview: self.image_preview.or(other.image_preview), | |||
| user_gutter_width: self.user_gutter_width.or(other.user_gutter_width), | |||
| external_edit_file_suffix: self | |||
| .external_edit_file_suffix | |||
| .or(other.external_edit_file_suffix), | |||
There was a problem hiding this comment.
I would be fine with an .unwrap_or_else(|| ".md".into()) here. iamb interprets the text as markdown, so that's probably the most useful default.
There was a problem hiding this comment.
Cool, PR updated.
ulyssa
changed the title
external_edit_file_suffix to config
|
Merged! Thank you for thinking to add this! 🎉 Getting syntax highlighting is I imagine one of people's big reasons to use an external editor, so this should make that much easier on them. (Although it would be nice to eventually implement it in the message bar, too.) |
|
Happy to help, and thank you for creating and maintaining iamb! |
This was referenced Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
editorcommand in iamb, the temporary file currently has no file extension. This is probably a reasonable default behavior, but some users may want to hint to their editor a particular file type such as.mdor.txtto make use of linters, formatters, spell checkers, or other file type specific editor configurations.This PR
preserves the default behaviorsets the default suffix to.mdwhile adding aexternal_edit_file_suffixconfiguration option which accepts a string to append to the end of the temporary file name passed to the users editor.